Turbonator SMEC codebase

[Stratman]

Do you see any problems with me using the B151 2.5 MTX cal and tuning the fueling, spark, and decel/accel tables? I noticed alot of differences in the AIS decel group between the two templates.

[ShelGame]

I don't have any idea if it will work well or not, to be honest...

[Stratman]

Rob,
I did a compare between my A553 code and your B151 code and changed all AIS values to match then drove the car around tonight. So far the RPM is not rising when decelerating to 5mph. I think it took a day or two before the problem started so I'm not going to get too excited. The next thing to do is to find the right table for AIS to rise RPMs when the AC compressor engages at idle.

EDIT: Come to think of it, I may just need the AIS to respond faster.

EDITx2: Also forgot to mention the code 53 I am getting now. I'm not sure if this is a checksum issue.

[ShelGame]

Ok, try this. On the 2.2 cals, the AIS steps table is a different format from the '89 T1. I think I kept the T1 table data in the T2 cals.

But, here is the translated T2 table data. Paste these tables into your template (A553-based templates only!!!) and see if it doesn't have a better idle. I'll keep looking for more...

FWDAIS_ForwardAisSteps_NoSlope:
       chem2 group "Idle - AIS Control"
       .chem 12 n ForwardAisSteps_NoSlope DeltaRPM 0 2048 rpm AISSteps 0 255 step FWDAIS Detailed_Description
       .byte   0x05    ; number of points
       .word   0x0a01  ; point 1
       .word   0x1402  ; point 2
       .word   0x1e04  ; point 3
       .word   0x2805  ; point 4
       .word   0x3206  ; point 5

	;.org	0x855f
REVAIS_ReverseAisSteps_NoSlope:
       chem2 group "Idle - AIS Control"
       .chem 12 n ReverseAisSteps_NoSlope DeltaRPM 0 2048 rpm AISSteps 0 255 step REVAIS Detailed_Description

       .byte   0x03    ; number of points
       .word   0x0aff  ; point 1
       .word   0x14fe  ; point 2
       .word   0x28fc  ; point 3

EDIT: actually, it looks like I originally copied the 2.2 T2 MP table for this data. That might explain the high idle. The MP cals did this on purpose to keep the revs high during shifts.

EDIT EDIT: Actually the scale was off, too. I corrected it...

[Aries_Turbo]

so is there a new file to download yet? didnt look like it yet.

Brian

[ShelGame]

No, I was hoping someone could test this fix first.

I want to re-test the dwell vs. bat volts mod before I post the next release.

[Stratman]

Ok, try this. On the 2.2 cals, the AIS steps table is a different format from the '89 T1. I think I kept the T1 table data in the T2 cals.

But, here is the translated T2 table data. Paste these tables into your template (A553-based templates only!!!) and see if it doesn't have a better idle. I'll keep looking for more...

FWDAIS_ForwardAisSteps_NoSlope:
       chem2 group "Idle - AIS Control"
       .chem 12 n ForwardAisSteps_NoSlope DeltaRPM 0 2048 rpm AISSteps 0 255 step FWDAIS Detailed_Description
       .byte   0x05    ; number of points
       .word   0x0a01  ; point 1
       .word   0x1402  ; point 2
       .word   0x1e04  ; point 3
       .word   0x2805  ; point 4
       .word   0x3206  ; point 5

	;.org	0x855f
REVAIS_ReverseAisSteps_NoSlope:
       chem2 group "Idle - AIS Control"
       .chem 12 n ReverseAisSteps_NoSlope DeltaRPM 0 2048 rpm AISSteps 0 255 step REVAIS Detailed_Description

       .byte   0x03    ; number of points
       .word   0x0aff  ; point 1
       .word   0x14fe  ; point 2
       .word   0x28fc  ; point 3

EDIT: actually, it looks like I originally copied the 2.2 T2 MP table for this data. That might explain the high idle. The MP cals did this on purpose to keep the revs high during shifts.

EDIT EDIT: Actually the scale was off, too. I corrected it...

That didn't really make any noticeable change. When I pasted this and opened the V16 file in MPTuner the first point of both tables do not start all the way at the Y axis. Not sure if that matters. What does matter...since I matched the "AIS Deccel" variables from the B151 cal into the A553 cal, I have had no problems. The only thing that hasn't fixed is the AIS keeping up 3 seconds worth of 300 RPMs at idle when the AC clutch suddenly engages. I'll be working on this next. The older cal I linked to in post #1014 handles the AC clutch engagement at idle very well, though the battery voltage control I modified in the old cal helps idle when an amp load is applied.

[Shadow]

Ok, try this. On the 2.2 cals, the AIS steps table is a different format from the '89 T1. I think I kept the T1 table data in the T2 cals.

But, here is the translated T2 table data. Paste these tables into your template (A553-based templates only!!!) and see if it doesn't have a better idle. I'll keep looking for more...

FWDAIS_ForwardAisSteps_NoSlope:
       chem2 group "Idle - AIS Control"
       .chem 12 n ForwardAisSteps_NoSlope DeltaRPM 0 2048 rpm AISSteps 0 255 step FWDAIS Detailed_Description
       .byte   0x05    ; number of points
       .word   0x0a01  ; point 1
       .word   0x1402  ; point 2
       .word   0x1e04  ; point 3
       .word   0x2805  ; point 4
       .word   0x3206  ; point 5

	;.org	0x855f
REVAIS_ReverseAisSteps_NoSlope:
       chem2 group "Idle - AIS Control"
       .chem 12 n ReverseAisSteps_NoSlope DeltaRPM 0 2048 rpm AISSteps 0 255 step REVAIS Detailed_Description

       .byte   0x03    ; number of points
       .word   0x0aff  ; point 1
       .word   0x14fe  ; point 2
       .word   0x28fc  ; point 3

EDIT: actually, it looks like I originally copied the 2.2 T2 MP table for this data. That might explain the high idle. The MP cals did this on purpose to keep the revs high during shifts.

EDIT EDIT: Actually the scale was off, too. I corrected it...

WTF? I sent a PM and now I'm in a thread?

[Stratman]

WTF? I sent a PM and now I'm in a thread?

It happens.

[Shadow]

It happens.

Your telling me! Still, was kind of bizzare to be sending a PM and all of a sudden everything lights up and your at the end of a long list of ppl in deep disscusion about a subject that you only have a limited understanding of.

Oh well, I'm here now, maybe if I pay attention I might learn something!

[ShelGame]

OK found another possible issue with the 2.2 cals.

The table 'PWADD' is used slightly differently between the T2 and T1 code. It might be work if you copy just this table over from one of the 2.5 templates. Otherwise, the AIS and spark scatter routines are identical. So, copying all of the tables/constants from the 2.5 probably won't be quite right. Looks like this table is only different between MTX and ATX (The stock and MP tables look the same), so just choose accordingly.

EDIT: Actually, use this table. The SBEC uses the exact same spark scatter fuel stabilization calculation as the SMEC. This is the 2.2 VNT/CSX table and shoud be correct for the 2.2 on T-SMEC. I'll update the templates and post later...

PWADD_FuelPWModifierFromBaro:
       chem2 group "Fuel - Transient Enrichment"
       .chem 0 1 AdditiveBaroFuelCompensation_FromBaro Baro -14.7 14.7 psi Pulsewidth 0 768 uSec PWADD Additive_Baro_Fuel_Compensation_-_fuel_added_based_on_altitude
       chem2 table inj PWADD simple use "Baro" -14.7 14.7 "psi" use "Pulsewidth" 0 768 "uSec" "Additive Baro Fuel Compensation - fuel added based on altitude"
       .inj table scale y
       .byte   0x03                              ; number of points in table
       .byte   0x55,  0x0B,  0xFF,  0xB7         ; point 1
       .byte   0x6A,  0x05,  0xFF,  0xC6         ; point 2
       .byte   0x80,  0x00                       ; point 3

FWIW, this is nearly the same table as the 2.5 MTX cals...

EDIT EDIT: Actually, the super-simple fix would be to set the PWADD table to 0 (the 2.2 cals are all set to 0xff). It only has an effect at low baro/high altitude settings. I doubt you will notice the difference between the table above and just using 0. You can make that change in the .bin file and not have to re-compile.

[Stratman]

This evening I found the fan is not coming on when in boost. I turned the "Fan turns on when map above baro plus this" to 0 and the fan still does not come on. I can't find another table to control this. Any ideas?

[ShelGame]

Can't think of any reason that would be. The 2 codes are identical in that area. What is your FANBAT set to?

[Stratman]

(-151.29) was/is the default.

[Stratman]

Rob,
This morning I found if the AC is on the ecu will turn off the radiator fan relay as well as the disengage AC clutch at WOT. Since the AC clutch will not engage if the rad fan relay is not on, it looks like the SMEC may be turning radiator fan relay off at WOT instead of the AC clutch relay. Is there a way to confirm this by looking at the code?

[ShelGame]

OK, I see what I think is causing that. I think I was experimenting with the fan control and forgot to change it back to stock.

Take this code:

	adda FANMAP_FanTurnsOnWhenMapAboveBaroPlusThis	  ;  (data is ff)
	bcs  TurnFanOff	  ; branch if lower
	bitb #pia1abuf_FanRelay	    ;  -00010000-
	beq  CheckFor_FANMAP	; branch if equal (zero)
	adda #0x02	    ;  -00000010-
	bcs  TurnFanOffByTimer	  ; branch if lower
CheckFor_FANMAP:
	cmpa MapValue	    ; compare a with memory contents
	bcc  TurnFanOff	  ; branch if greater or equal

And make it look like this:

	adda FANMAP_FanTurnsOnWhenMapAboveBaroPlusThis	  ;  (data is ff)
	bcs  TurnFanOffByTimer	  ; branch if lower
	bitb #pia1abuf_FanRelay	    ;  -00010000-
	beq  CheckFor_FANMAP	; branch if equal (zero)
	adda #0x02	    ;  -00000010-
	bcs  TurnFanOffByTimer	  ; branch if lower
CheckFor_FANMAP:
	cmpa MapValue	    ; compare a with memory contents
	bcc  TurnFanOffByTimer	  ; branch if greater or equal

Basically, there are 2 spots where the fan is supposed to be turned off after a timer expires, instead, I have it turning off immediately.

I'll have this fixed in the next posted update.

[ShelGame]

Also, I think the scale is wrong for FANBAT. The ambient temp sensor (battery temp sensor) must not use the same scaling as the coolant temp sensor. I'll try to figure out what it really is...

[zin]

The ambient temp sensor (battery temp sensor) must not use the same scaling as the coolant temp sensor.

I've always been curious about this one... Does the computer have a thermistor on board? Is is an interpolated thing or is there a sensor floating around I don't know about? I would suspect it to be on-board, but don't know for sure...

Mike

[ShelGame]

I've always been curious about this one... Does the computer have a thermistor on board? Is is an interpolated thing or is there a sensor floating around I don't know about? I would suspect it to be on-board, but don't know for sure...

Mike

Yes, it's on-board. It's right next to the EPROM, actually.

[Stratman]

Fan still not activating under boost with the change and is still turning of the rad fan if WOT and AC on.